Skip to content

Use MetadataLogFileIndex to get latest version in AddDateVersionTransformer#308

Merged
kevinwallimann merged 6 commits intodevelopfrom
fix/use-MetadataLogFileIndex-to-get-latest-version-in-add-date-version-transformer
Jun 16, 2025
Merged

Use MetadataLogFileIndex to get latest version in AddDateVersionTransformer#308
kevinwallimann merged 6 commits intodevelopfrom
fix/use-MetadataLogFileIndex-to-get-latest-version-in-add-date-version-transformer

Conversation

@jozefbakus
Copy link
Collaborator

Use MetadataLogFileIndex to get latest version in AddDateVersionTransformer

@jozefbakus jozefbakus self-assigned this May 19, 2025
kevinwallimann
kevinwallimann previously approved these changes May 19, 2025
Copy link
Collaborator

@kevinwallimann kevinwallimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only formatting

fileCatalog.partitionSpec().partitions.map { partition =>
val row: InternalRow = partition.values
(row.getString(0), row.getInt(1))
}.filter { case (date, _) => date == reportDate }.map { case (_, version) => version }.toList
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting could be clearer (.map and .toList on a new line)

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

JaCoCo code coverage report - Scala 2.11 & Spark 2

File Coverage [90.8%] 🍏
CompatibleSparkUtilProvider.scala 100% 🍏
SparkUtil.scala 100% 🍏
MetadataLogUtil.scala 92% 🍏
AddDateVersionTransformer.scala 87.77% 🍏
Total Project Coverage 75.01% 🍏

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

JaCoCo code coverage report - Scala 2.12 & Spark 2

File Coverage [89.53%] 🍏
CompatibleSparkUtilProvider.scala 100% 🍏
SparkUtil.scala 100% 🍏
MetadataLogUtil.scala 91.21% 🍏
AddDateVersionTransformer.scala 85.84% 🍏
Total Project Coverage 74.18% 🍏

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

JaCoCo code coverage report - Scala 2.12 & Spark 3

File Coverage [89.63%] 🍏
CompatibleSparkUtilProvider.scala 100% 🍏
SparkUtil.scala 100% 🍏
MetadataLogUtil.scala 91.21% 🍏
AddDateVersionTransformer.scala 85.84% 🍏
Total Project Coverage 72.85% 🍏

@kevinwallimann kevinwallimann marked this pull request as ready for review June 16, 2025 14:40
@kevinwallimann kevinwallimann merged commit e6c2ad8 into develop Jun 16, 2025
3 checks passed
@kevinwallimann kevinwallimann deleted the fix/use-MetadataLogFileIndex-to-get-latest-version-in-add-date-version-transformer branch June 16, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants